Add cis function#101
Merged
bors[bot] merged 5 commits intorust-num:masterfrom Apr 29, 2022
rayhem:master
Merged
Conversation
cuviper
reviewed
Apr 26, 2022
cuviper
reviewed
Apr 26, 2022
cuviper
reviewed
Apr 26, 2022
cuviper
reviewed
Apr 27, 2022
Member
|
Looks good! bors r+ |
Contributor
|
Build succeeded: |
Author
|
Thank you for the review @cuviper and for making it easy to make my first Rust PR! |
Member
Author
Member
|
I can't change the file in the published artifacts, but I've updated the release notes anyway. I believe GitHub simply looks at the commit's author email to make that association. It will also indicate a separate committer if that's different, as seen in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a cis function as a convenient way to construct a complex number with a specific phase/angle. Shorthand for
(Complex::i() * angle).exp().