Symfony 6 compatibility#125
Symfony 6 compatibility#125studio-m2v wants to merge 14 commits intorvanlaak:3.xfrom studio-m2v:master
Conversation
|
@dmishh can we have this? |
|
What I am curious about is why tests do not get executed. Can you rebase on master? |
|
@dmishh yes please do! But, maybe @FriendsOfSymfony or another group is even a better and more sustainable place? |
|
@rvanlaak I'd rather transfer to your account since you were the main contributor all the time after I stopped supporting the project. How about the packagist name or anything else required to make the transfer smooth for the users? |
|
Yes, please feel free to do so. |
|
@rvanlaak how about the packagist settings, etc? Should there be some changes, so it doesn't fall apart? |
|
Can you add me as maintainer on Packagist first? That way I can make sure to update the reference once the ownership on Github was transferred. |
|
@rvanlaak I just added you to the maintainers list - https://packagist.org/packages/dmishh/settings-bundle |
|
Feel free to transfer the repo @dmishh , thanks for your effort! |
|
@rvanlaak you need to delete the repo fork in your account first. Please, do so and let me know. Thanks |
|
Removed my fork ✅ |
|
@rvanlaak great! "Repository transfer to rvanlaak requested" Thanks for supporting the bundle! |
|
Thanks @rvanlaak for takeing over the repo. |
|
@dmishh in order to not mess up possible packagist installations (as I was OoO for some days), I've not accepted the transfer yet and it now has expired. Can you resend it? |
|
@rvanlaak yep, I just initiated the transfer again |
|
Done! Updated the Packagist settings accordingly and left a note on README for clarity. Thank you @dmishh ! |
Some changes to be compatible with Symfony 6 and PHP 8.x