You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure or naming it namespace is the correct way to go, sounds a bit confusing to me. What about naming it something like group or settingGroup or collection ? Can we also make sure there is a testcase for this? 🚀
Lots of things have happened since you created this PR 5 hours ago. I think this is a great idea. @rvanlaak had some very good comments that we should address first.
i'm back. the original idea of calling it namespace was, that the value of the option is actually a class namespace. i'll continue on the other thread..
btw. testcases. i may take a little bit longer with that, as i'm not use to write tests on php..
Push something and we will help you.
Also, be aware that you need to rebase your work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
namespaceoption, when using the scopeuser, this way it is possible to register settings for different classes.