Add 'Request::version()' to return hyper version (non-local)#2930
Closed
hcldan wants to merge 1 commit intorwf2:masterfrom
Closed
Add 'Request::version()' to return hyper version (non-local)#2930hcldan wants to merge 1 commit intorwf2:masterfrom
hyper version (non-local)#2930hcldan wants to merge 1 commit intorwf2:masterfrom
Conversation
the10thWiz
added a commit
that referenced
this pull request
May 4, 2025
- Based on #2930 - Populates value from hyper version - Adds method to override version for local requests
Collaborator
|
Merged (with changes) in 4358dae |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a method (
Request::version()) to return the hyper version of the request.It is optional so that local clients don't need to deal with it. It seemed like overkill to add the extra arg to all the local client request methods. I'm not sure how to deal with an example or test for this unless you end up wanting to expose it to the local clients, but I don't know if it makes sense to in that context.