ci: add action-sh-checker to lint and format shell scripts#224
Draft
agilgur5 wants to merge 1 commit intoryanrudolfoba:mainfrom
Draft
ci: add action-sh-checker to lint and format shell scripts#224agilgur5 wants to merge 1 commit intoryanrudolfoba:mainfrom
action-sh-checker to lint and format shell scripts#224agilgur5 wants to merge 1 commit intoryanrudolfoba:mainfrom
Conversation
- c.f. https://github.com/luizm/action-sh-checker - this will run `shfmt` for formatting, `shellcheck` for static analysis, etc - security: this GHA Workflow follows [OpenSSF Scorecard best practices](https://github.com/ossf/scorecard/blob/43d5832d25ccc597a9b94926b6ad43da25204085/docs/checks.md) - c.f. "Dangerous Workflow", "Pinned Dependencies", and "Token-Permissions" in particular
agilgur5
force-pushed
the
ci-sh-checker
branch
from
f957d42 to
56a9b7b
Compare
Contributor
Author
|
Looks like Actions aren't enabled in this repo? GH Docs link I'll probably need to test CI in my own fork either way though |
This was referenced Jan 15, 2025
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a simple CI workflow purely to lint and format shell scripts
Starts (but does not complete) #202. Addresses #201 "Future Work"
Details
c.f. https://github.com/luizm/action-sh-checker
shfmtfor formatting,shellcheckfor static analysis, etcshfmtin particular would help with whitespace issues as in Added the Ability to install Android TV ROM #220 (comment)security: this GHA Workflow follows OpenSSF Scorecard best practices
Notes to Reviewers
This is a Draft PR for now as existing code will likely fail