UDP override#4
Merged
Merged
Conversation
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
|
This looks good to me! For a future iteration: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves UDP to a similar architecture to how TCP works after #2.
The
UdpSockettrait sets out all of the overrideable features for UDP including the ability to generate outgoing and incoming streams which themselves can be overwritten with custom logic.The
OutgoingStreamandIncomingStreamtraits might need further adjustment. Currently they both require implementors to implement areadyfunction for when the streams can be written to/read from. Perhaps it's possible to refactor this such that only one function is needed that can both signal readiness and allow for the actual writing/reading, but my attempt to come up with a design for that came up short.