fix: Update deprecated timezone names#756
Open
ralflang wants to merge 1 commit intosabre-io:masterfrom
Open
Conversation
Systems without the tzdata-legacy package, i.e. (Ubuntu 24.04+) reject deprecated names. Examples: Europe/Kiev, Asia/Calcutta, America/Godthab This causes FindFromTimezoneMap::find() to throw. Update all 13 occurrences across windowszones, lotuszones and exchangezones maps to their canonical replacements and wrap DateTimeZone instantiation in try/catch for resilience against future renames. Comes with unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #755 which was based against the current maintenance branch and thus had a huge, misleading diff.
fix(timezonedata): Replace deprecated IANA timezone names
Systems without the tzdata-legacy package, i.e. (Ubuntu 24.04+) reject deprecated names.
Examples: Europe/Kiev, Asia/Calcutta, America/Godthab
This causes FindFromTimezoneMap::find() to throw.
Update all 13 occurrences across windowszones, lotuszones and exchangezones maps to their canonical replacements and wrap DateTimeZone instantiation in try/catch for resilience against future renames.
Comes with unit test