Missing parameter validation on setCookie function causes TypeError

[fabiante]

I noticed missing parameter validation in the setCookie function:

tough-cookie/lib/cookie.js

Lines 995 to 1001 in 4350705

	CookieJar.prototype.setCookie = function(cookie, url, options, cb) {
	var err;
	var context = getCookieContext(url);
	if (options instanceof Function) {
	cb = options;
	options = {};
	}

There is no parameter validation which may cause confusion when not setting url. If only cookies then the function will assume that the options parameter is an object and tries to access the loose property. This will cause a TypeException.

There should either be parameter validation throwing an Error or some kind of handling.

This was found when investigating this bug: valeriangalliat/fetch-cookie#35

[stash]

Agree that this could have a much better error raised than TypeError. Pull request would be welcome :)

Other methods besides setCookie could benefit from clearer error messages too, for what it's worth.

[ruoho]

@fabiante Sorry for the delay, this should be fixed in the latest pull request. Can you verify?