Support publishing of both ESM and CJS#536
Merged
Merged
Conversation
The [ESM supported backported to Node 20.19.0](https://github.com/nodejs/node/releases/tag/v20.19.0) is nice but not sufficient for supporting users on earlier versions of Node v20 which is still in active maintenance until 2026-04-30. This PR adds in dual-publishing of both ESM and CJS and ensures that entrypoints and types are correctly declared.
wjhsf
previously approved these changes
Jul 31, 2025
Contributor
wjhsf
left a comment
wjhsf
left a comment
There was a problem hiding this comment.
Can you add tests that require('tough-cookie') and await import('tough-cookie') both work?
Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com>
Contributor
Author
|
@wjhsf added tests for verifying ESM and CJS in 337440f and 4d98f2c. See https://github.com/salesforce/tough-cookie/actions/runs/16656635134/job/47143177365?pr=536 Also verified locally that |
wjhsf
previously approved these changes
Jul 31, 2025
wjhsf
previously approved these changes
Aug 1, 2025
* master: Bump the dev-dependencies group with 8 updates (#537) # Conflicts: # package-lock.json
wjhsf
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ESM supported backported to Node 20.19.0 is nice but not sufficient for supporting users on earlier versions of Node v20 which is still in active maintenance until 2026-04-30. This PR adds in dual-publishing of both ESM and CJS and ensures that entrypoints and types are correctly declared.