Fix openstack cloud driver to work with only bootstrapping#21283
Merged
thatch45 merged 7 commits intosaltstack:developfrom Mar 4, 2015
Merged
Fix openstack cloud driver to work with only bootstrapping#21283thatch45 merged 7 commits intosaltstack:developfrom
thatch45 merged 7 commits intosaltstack:developfrom
Conversation
Contributor
Author
|
@rallytime This might be worthwhile to backport to 2014.7 if there are plans to do a .3. |
Contributor
Author
Contributor
Author
|
I don't know why pylint is still checking the old one, but i fixed 23:15:33 salt/cloud/clouds/openstack.py:389: [W0102(dangerous-default-value), networks] Dangerous default value {} as argument That should default to None now, and if it is none, change it to {} inside the function. |
To None?
Contributor
Author
|
maybe i didn't push it yet... |
Contributor
Author
|
Huzzah |
Contributor
Author
|
@rallytime it should definitely make it back into 2015.2 |
jfindlay
added
Master Change
bugfix-bckport
thatch45
added a commit
that referenced
this pull request
Mar 4, 2015
Fix openstack cloud driver to work with only bootstrapping
Contributor
|
@cro ping |
rallytime
added
Bugfix - [Done] back-ported
and removed
bugfix-bckport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This needs to be added so that it servers can be just bootstrapped with the cloud.create runner.
I split out the networks to a separate function, cause it is needed later for the wait_ for ip function.
(I am directly modifying the object, so it doesn't need to be returned)
closes #20932
Thanks,
Daniel