Fix option to handle type conversion

[mtsoltan]

Conversion doesn't happen automatically when using mo.Option to accept from drivers, or inside gorm model structs.

The test cases assert the desired behavior, and fail on upstream before this PR, but pass after the changes made.

This supersedes #34, which can now be closed once this is successfully merged.

[mtsoltan]

This also resolves #24

Edits by maintainers are allowed, in case you want to change something with my comment style. ^.^ Cheers!

[samber]

Thanks @mtsoltan for your first contribution.

Love it!

Could you please make it compatible with go < 1.22?

You can split it into 3 files:

• option.go
• option_go118.go
• option_go122.go

A build condition can be added at the top of the file using //go:build !go1.22.

[mtsoltan]

Check the last commit. I went through great deals of verification to make sure all access patterns of convertAssign inside the 1.18 standard library do not expose it. There's simply no way to access that function, so the only solution was to copy it :(

This introduces the debt of maintaining it with this PR, but honestly, given how stable that function is in the standard library of 1.18, I think it's a fair trade in order to achieve a working Scan.

Let me know what you think.

[samber]

Did not know this syntax before.

It seems that it has been deprecated in go 1.17. So it would be unnecessary in this project (mo supports >= 1.18).

[samber]

-> v1.13.0