Bugfix - add/remove items from muuri grid#17
Merged
Conversation
aliciakw
force-pushed
the
bugfix/draggable-reorder
branch
from
5b7ee8d to
0bdcc37
Compare
aliciakw
force-pushed
the
bugfix/draggable-reorder
branch
from
0bdcc37 to
6380e49
Compare
limsohee1002
approved these changes
Jan 10, 2019
| set(this, 'editingUUID', uuid); | ||
| // TODO: re-enable this after muuri rerender on "iEditing" | ||
| // bug is fixed | ||
| // set(this, 'editingUUID', uuid); |
Contributor
There was a problem hiding this comment.
So was this the problem child? While editing it doesn't factor in new elements?
Contributor
Author
There was a problem hiding this comment.
This is the outstanding issue... the grid layout does not recalculate heights upon clicking "edit", and the method to force it to do so is not working.
joshiefishbein
approved these changes
Jan 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add callbacks so that muuri grid will update when entries are added/removed.
This fixes...
an issue where adding a new entry would cause it to be positioned behind the existing grid, rather than becoming part of the existing grid.
But, not yet perfect...
Need to force grid to recalculate the height of all items + re-render when editingUUID changes.
Something like
But "refreshItems" is not behaving as expected so this issue is still outstanding.
To Test:
set
const DEV = true;in application.js & navigate to localhost:4200. Confirm that functionality is improved.