fix(ClientPermissions): check app permissions when used with user apps#797
Merged
favna merged 3 commits intosapphiredev:mainfrom Nov 4, 2024
Merged
Conversation
vladfrangu
requested changes
Nov 3, 2024
kyranet
reviewed
Nov 3, 2024
Co-authored-by: Aura <kyradiscord@gmail.com>
this.ok when channel is null
favna
approved these changes
Nov 4, 2024
vladfrangu
approved these changes
Nov 4, 2024
| if (interaction.channel) { | ||
| if (interaction.channel.isDMBased()) return this.dmChannelPermissions; | ||
|
|
||
| const channel = await this.fetchChannelFromInteraction(interaction); |
Member
There was a problem hiding this comment.
This fetch feels redundant now
Member
There was a problem hiding this comment.
Better safe than sorry and it's gonna come out of the cache anyway if it's there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interaction.channelwill always be null when used with user-installable and sinceClientPermissionsalways fetch the invoked interaction channel, it will throw an error causing "The application did not respond"framework/src/lib/structures/Precondition.ts
Lines 51 to 58 in 7ae8c5b