Gpu test for VectorFieldPosterior#1542
Merged
janfb merged 4 commits intosbi-dev:mainfrom Mar 28, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
===========================================
- Coverage 89.45% 78.94% -10.52%
===========================================
Files 128 133 +5
Lines 10170 10370 +200
===========================================
- Hits 9098 8187 -911
- Misses 1072 2183 +1111
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
janfb
requested changes
Mar 28, 2025
Contributor
janfb
left a comment
There was a problem hiding this comment.
Looks good, thanks @jorobledo !
added a couple of small suggestions / typo fixes.
Co-authored-by: Jan <janfb@users.noreply.github.com>
janfb
approved these changes
Mar 28, 2025
Contributor
|
thanks @jorobledo , looks perfect now! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following PR #1527 and issue #1530 , improved the test for vector field methods.
FMPEandNPSEsince they are redundant (both share log_prob implementation)._lossfunction not being on the same device when moving to device the training.This one is small! Let me know if anything is missing or you think that it can be improved @StarostinV @janfb