You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 25.45455% with 41 lines in your changes missing coverage. Please review. ⚠️ Please upload report for BASE (main@7d66b89). Learn more about missing BASE report. ⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.
❌ Your patch check has failed because the patch coverage (25.45%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.
The codecov patch failure is expected. The new code paths PosteriorBuilder.sample(), PosteriorBuilder.log_prob(), and VectorFieldBasedPotential.init() are all covered by the slow tests in tests/test_posterior_builder.py which require a trained NPSE model. These are marked @pytest.mark.slow and don't run in CI's fast test suite.The fast test test_base_potential_init_is_noop covers the BasePotential change (93.1%). Happy to add mock-based fast tests for the remaining lines if preferred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce an explicit init() method for potentials to allow one-time setup
instead of relying on runtime caching.
Changes
Tests
All tests pass locally. One test is marked xfail intentionally because the
behavior is expected to fail by design.
Closes #1783