Skip to content

Trim whitespace from admin detail fields before saving#574

Merged
rumblefrog merged 1 commit intosbpp:v1.xfrom
geominorai:patch/admindetails_trim
Jun 21, 2019
Merged

Trim whitespace from admin detail fields before saving#574
rumblefrog merged 1 commit intosbpp:v1.xfrom
geominorai:patch/admindetails_trim

Conversation

@geominorai
Copy link
Contributor

Trims leading/trailing whitespace from admin name, email, and auth ID fields from POST parameters

Motivation and Context

Fields were not trimmed and were allowed to persist into the DB like this, which can cause problems later when read out for use as-is without sanitization. AuthID in particular can store whitespace without being noticed since the field gets trimmed before being displayed on the page.

How Has This Been Tested?

Tested on Apache web server
Edited admin detail with a copious amount of leading/trailing whitespace in the fields are now properly trimmed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@rumblefrog rumblefrog merged commit 2281114 into sbpp:v1.x Jun 21, 2019
@geominorai geominorai deleted the patch/admindetails_trim branch June 22, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants