Skip to content

refactor: Standardized Main Chat Prints#614

Merged
rumblefrog merged 1 commit intov1.xfrom
standardize-chat-prints
Oct 4, 2019
Merged

refactor: Standardized Main Chat Prints#614
rumblefrog merged 1 commit intov1.xfrom
standardize-chat-prints

Conversation

@rumblefrog
Copy link
Member

Description

Removes duplicate Sourcebans and standardized them to Prefix define

Motivation and Context

Clean up and standardization

How Has This Been Tested?

Successfully compiles

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@CrazyHackGUT
Copy link
Contributor

Maybe you move prefix to translations file?

@rumblefrog
Copy link
Member Author

Perhaps in another PR.

@rumblefrog rumblefrog merged commit 3748c89 into v1.x Oct 4, 2019
@rumblefrog rumblefrog deleted the standardize-chat-prints branch October 4, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants