Skip to content

Fix invalid XML response when gameservers use special characters.#640

Merged
rumblefrog merged 1 commit intosbpp:v1.xfrom
sm9cc:XML-Escape-HostName
Mar 18, 2020
Merged

Fix invalid XML response when gameservers use special characters.#640
rumblefrog merged 1 commit intosbpp:v1.xfrom
sm9cc:XML-Escape-HostName

Conversation

@sm9cc
Copy link
Contributor

@sm9cc sm9cc commented Jan 22, 2020

Description

Gameservers like to use special characters, this breaks the XML response in a lot of cases.

Motivation and Context

A friend asked me to help him fix it.

How Has This Been Tested?

Visited the sourcebans web page and observed that the gameserver name shows correctly and the XML error no longer exists.

Screenshots (if appropriate):

https://i.imgur.com/kiHqPWF.png (https://bans.cswarzone.com/index.php?p=servers)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.

@rumblefrog rumblefrog requested a review from Groruk January 23, 2020 21:42
@rumblefrog rumblefrog added semver: patch t: ui/ux template: used Issue is written in the issue template labels Jan 23, 2020
@rumblefrog rumblefrog merged commit 8d1ecb8 into sbpp:v1.x Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: patch t: ui/ux template: used Issue is written in the issue template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants