Skip to content

Optimize oplog size by stripping locations of large objects#2715

Merged
bert-e merged 7 commits intodevelopment/9.3from
improvement/BB-491/strip-oplog-location
Mar 2, 2026
Merged

Optimize oplog size by stripping locations of large objects#2715
bert-e merged 7 commits intodevelopment/9.3from
improvement/BB-491/strip-oplog-location

Conversation

@delthas
Copy link
Copy Markdown
Contributor

@delthas delthas commented Feb 12, 2026

Issue: BB-491

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 12, 2026

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 12, 2026

Codecov Report

❌ Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.48%. Comparing base (02d23c5) to head (145f7a6).
⚠️ Report is 7 commits behind head on development/9.3.

Files with missing lines Patch % Lines
extensions/oplogPopulator/OplogPopulatorTask.js 0.00% 3 Missing ⚠️
extensions/replication/tasks/ReplicateObject.js 87.50% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
extensions/oplogPopulator/OplogPopulator.js 89.14% <100.00%> (ø)
...ns/oplogPopulator/OplogPopulatorConfigValidator.js 100.00% <ø> (ø)
extensions/oplogPopulator/modules/Connector.js 90.29% <100.00%> (+5.18%) ⬆️
...nsions/oplogPopulator/modules/ConnectorsManager.js 94.07% <100.00%> (ø)
...pulator/pipeline/MultipleBucketsPipelineFactory.js 100.00% <100.00%> (ø)
...ensions/oplogPopulator/pipeline/PipelineFactory.js 100.00% <100.00%> (ø)
...oplogPopulator/pipeline/WildcardPipelineFactory.js 100.00% <100.00%> (ø)
extensions/replication/tasks/ReplicateObject.js 91.20% <87.50%> (-0.14%) ⬇️
extensions/oplogPopulator/OplogPopulatorTask.js 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.37% <ø> (ø)
Core Library 80.69% <ø> (-0.50%) ⬇️
Ingestion 71.14% <ø> (ø)
Lifecycle 78.62% <ø> (ø)
Oplog Populator 85.83% <90.62%> (+0.76%) ⬆️
Replication 59.65% <87.50%> (+0.09%) ⬆️
Bucket Scanner 85.76% <ø> (ø)
@@                 Coverage Diff                 @@
##           development/9.3    #2715      +/-   ##
===================================================
- Coverage            74.62%   74.48%   -0.15%     
===================================================
  Files                  200      200              
  Lines                13573    13603      +30     
===================================================
+ Hits                 10129    10132       +3     
- Misses                3434     3461      +27     
  Partials                10       10              
Flag Coverage Δ
api:retry 9.14% <0.00%> (-0.03%) ⬇️
api:routes 8.96% <0.00%> (-0.03%) ⬇️
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 10.02% <0.00%> (-0.88%) ⬇️
ingestion 12.55% <0.00%> (-0.03%) ⬇️
lib 7.61% <0.00%> (-0.03%) ⬇️
lifecycle 18.85% <0.00%> (-0.06%) ⬇️
notification 1.03% <0.00%> (-0.01%) ⬇️
oplogPopulator 0.14% <20.83%> (?)
replication 18.49% <29.16%> (-0.01%) ⬇️
unit 51.01% <60.41%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scality scality deleted a comment from bert-e Feb 12, 2026
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Feb 12, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@delthas
Copy link
Copy Markdown
Contributor Author

delthas commented Feb 12, 2026

Manually tested with varying values and single-part, empty, and multi-part objects, works.

Also manually tested changing the configuration on the fly, properly applies, and properly resumes the pipeline with the token.

@delthas delthas force-pushed the improvement/BB-491/strip-oplog-location branch from d48fd8a to e34f3dc Compare February 24, 2026 12:04
@delthas delthas force-pushed the improvement/BB-491/strip-oplog-location branch 2 times, most recently from d4ad94a to db7640b Compare February 25, 2026 09:08
@delthas
Copy link
Copy Markdown
Contributor Author

delthas commented Feb 25, 2026

Tested on a live cluster, working.

delthas added 3 commits March 2, 2026 12:10
Issue: BB-491
Signed-off-by: Thomas Flament <thomas.flament@scality.com>
This saves space on the Kafka side while preventing a refetch
on most (small) objects.

Issue: BB-491
Signed-off-by: Thomas Flament <thomas.flament@scality.com>
Issue: BB-491
Signed-off-by: Thomas Flament <thomas.flament@scality.com>
@delthas delthas force-pushed the improvement/BB-491/strip-oplog-location branch from e4f4a16 to acf2e47 Compare March 2, 2026 11:12
@scality scality deleted a comment from bert-e Mar 2, 2026
@delthas delthas force-pushed the improvement/BB-491/strip-oplog-location branch from acf2e47 to 295bd53 Compare March 2, 2026 11:16
@delthas delthas force-pushed the improvement/BB-491/strip-oplog-location branch from 295bd53 to 3ee4bad Compare March 2, 2026 11:39
@delthas
Copy link
Copy Markdown
Contributor Author

delthas commented Mar 2, 2026

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Mar 2, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.3

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/9.0
  • development/9.1
  • development/9.2

Please check the status of the associated issue BB-491.

Goodbye delthas.

The following options are set: approve

@bert-e bert-e merged commit 145f7a6 into development/9.3 Mar 2, 2026
22 checks passed
@bert-e bert-e deleted the improvement/BB-491/strip-oplog-location branch March 2, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants