Skip to content

chart, salt: Add annotations to fluent-bit pod#4834

Open
eg-ayoub wants to merge 2 commits intodevelopment/133.0from
improvement/ensure-fluent-bit-restarted
Open

chart, salt: Add annotations to fluent-bit pod#4834
eg-ayoub wants to merge 2 commits intodevelopment/133.0from
improvement/ensure-fluent-bit-restarted

Conversation

@eg-ayoub
Copy link
Contributor

What/How: Add annotations containing configmap and secret to fluent-bit pod
Why: so it is restarted whenever these objects are updated.

MK8S-203

@eg-ayoub eg-ayoub requested a review from a team as a code owner March 23, 2026 11:07
@bert-e
Copy link
Contributor

bert-e commented Mar 23, 2026

Hello eg-ayoub,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 23, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Peer approvals must include at least 1 approval from the following list:

TeddyAndrieux
TeddyAndrieux previously approved these changes Mar 23, 2026
TeddyAndrieux
TeddyAndrieux previously approved these changes Mar 23, 2026
@eg-ayoub eg-ayoub force-pushed the improvement/ensure-fluent-bit-restarted branch from 2164dbc to e5434b1 Compare March 24, 2026 08:45
Add annotations containing configmap and secret to fluent-bit pod so it
is restarted whenever these objects are updated.

MK8S-203
@eg-ayoub eg-ayoub force-pushed the improvement/ensure-fluent-bit-restarted branch from e5434b1 to 6ca6b22 Compare March 24, 2026 14:29
@claude
Copy link

claude bot commented Mar 24, 2026

  • CHANGELOG.md: Typo — "it's" should be "its" (possessive form)
    - Replace "it's configmap" with "its configmap"

    Review by Claude Code

@eg-ayoub eg-ayoub force-pushed the improvement/ensure-fluent-bit-restarted branch from 6ca6b22 to 87c360c Compare March 24, 2026 14:35
@claude
Copy link

claude bot commented Mar 24, 2026

LGTM

The changes correctly replace the static (and useless) checksum annotation and the prometheus annotations with dynamic Salt slot-based digests for the ConfigMap and Secret, following the same established pattern used in calico and kube-proxy. The data: {} addition to the initial Secret manifest ensures get_object_digest(path="data") won't fail on first deployment. Prometheus scraping is already covered by the ServiceMonitor, so removing the prometheus.io/* annotations has no functional impact.

Review by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants