Fix crash with overlapping filenames#835
Open
alexcraven wants to merge 1 commit intoschorschinho:Osprey3.0from
Open
Fix crash with overlapping filenames#835alexcraven wants to merge 1 commit intoschorschinho:Osprey3.0from
alexcraven wants to merge 1 commit intoschorschinho:Osprey3.0from
Conversation
Correction to the check for overlapping filenames at the top of OspreyCoreg (which triggered schorschinho#834)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction to the check for overlapping filenames at the top of
OspreyCoreg(which triggered #834), for non-BIDS datasets.Previous version only checked the first two items in
MRSCont.files, hence was only reliable if all filenames were identical. Updated version catches the case where any names overlap.Tested for GE P-files, where names tend to differ, but are not guaranteed unique.
The original code also handled the case where the files list contained directories rather than individual folders; updated code should also handle this elegantly, but has only been tested with hypothetical lists.