-
Notifications
You must be signed in to change notification settings - Fork 25
Add pip install with editable mode #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just want to clarify that this is moving in the right direction? |
stefanv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments, but this is pretty much the gist of it, yes!
spin/cmds/pip.py
Outdated
| pip arguments are passed through in the same manner as you would pip e.g.: | ||
| spin install -- -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this example make sense? I'd read it as:
pip install . --editable --no-build-isolation -r requirements.txt
which doesn't make so much sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, I clarified and edited slightly. With the new logic of the install function, hopefully this is better?
stefanv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good; you should also add this to the CI test.sh to ensure that it does what you expect it to.
spin/cmds/pip.py
Outdated
| pip arguments are passed through in the same manner as you would pip e.g.: | ||
| spin install -- -r requirements.txt --editable false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point was that you probably don't want to do this. You want something like: spin install -- --no-clean or another option that makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see. sure that makes sense. I edited the example
spin/cmds/pip.py
Outdated
| if editable: | ||
| pip_args += ["--no-build-isolation", "--editable"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe --no-build-isolation should be used in both cases? I.e.,pip_cmd = ["pip", "install", ".", "--no-build-isolation"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure fair.
|
And to |
|
Few questions:
|
Signed-off-by: Adam Li <[email protected]>
|
Thanks @adam2392! |
Closes: #138