Skip to content

pytest: use PYTHONPATH, not ., as first entry in sys.path #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stefanv merged 1 commit into from
Feb 11, 2024
Merged

pytest: use PYTHONPATH, not ., as first entry in sys.path #166

stefanv merged 1 commit into from
Feb 11, 2024

Conversation

@stefanv
Copy link
Member

@stefanv stefanv commented Feb 7, 2024

Python 3.11 has the -P flag. For other Pythons, we invoke pytest directly, which seems to handle PYTHONPATH correctly.

Closes #165

@stefanv
pytest: use PYTHONPATH, not ., as first entry in sys.path
1b9b84e 
Python 3.11 has the `-P` flag. For other Pythons, we invoke `pytest`
directly, which seems to handle PYTHONPATH correctly.

Closes scientific-python#165
@stefanv stefanv added the type: Maintenance Refactoring and maintenance of internals label Feb 7, 2024
@stefanv stefanv merged commit 26b55f8 into scientific-python:main Feb 11, 2024
@jarrodmillman jarrodmillman added this to the 0.9 milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

+1 more reviewer

@akhmerov akhmerov akhmerov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: Maintenance Refactoring and maintenance of internals

Projects

None yet

Milestone

0.9

Development

Successfully merging this pull request may close these issues.

spin test fails after spin install

3 participants

@stefanv @jarrodmillman @akhmerov