-
Notifications
You must be signed in to change notification settings - Fork 25
Fix testing for editable and non-editable installs alike #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f656a73 to
9f01bb4
Compare
|
@ngoldbaum This should fix the problems with NumPy, hopefully. There's still one problem due to the way NumPy overrides this command, such that |
|
@jarrodmillman Given that the current test command is broken, I recommend we do this as a point release, but we could also just do a 0.11. |
Sounds reasonable. Care to elaborate a little bit? |
|
Sure! The user is supposed to supply tests as |
|
I tried testing this after implementing the suggested change to numpy's spin configuration, but I'm still getting an error trying to do This is coming from here: Line 49 in b705a48
I don't know enough about how |
|
OK, I thought we patched that; let me check why that error is still present for you. |
|
That wasn't supposed to close. Reopened as #213 |
Work to address #209, #203, #204, #208