refactor: define common nplike method to get pointer to memory#3565
Merged
pfackeldey merged 1 commit intomainfrom Jul 6, 2025
Merged
refactor: define common nplike method to get pointer to memory#3565pfackeldey merged 1 commit intomainfrom
pfackeldey merged 1 commit intomainfrom
Conversation
Collaborator
|
@pfackeldey I like this abstraction a lot actually! |
ianna
approved these changes
Jul 3, 2025
Member
ianna
left a comment
ianna
left a comment
There was a problem hiding this comment.
@pfackeldey - This is great! Thanks for cleaning it up!
Member
|
@pfackeldey - please feel free to merge it if you are done with it. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines a
memory_ptrfunction for each nplike and thus unifies their interface throughout the codebase (as suggested in #3413).Closes #3413