fix: overflow error when concatenating more than 128 regular arrays#3568
Merged
fix: overflow error when concatenating more than 128 regular arrays#3568
Conversation
ianna
requested changes
Jul 6, 2025
Member
ianna
left a comment
There was a problem hiding this comment.
@ikrommyd - Looks good! Thanks for providing the fix so quickly! This is the right solution since all the kernels involved have specialization for int64 and both UnionArray functions regular_index and simplified allow Index64 as tags. It would help if we add a test where simplified fails to reduce to no more than 128 variants. Please see the comments. Thanks!
# Note: to help merge more than 128 arrays, tags *can* have type ak.index.Index64.
# This is only supported when index is also Index64,
# and all indexed contents are also Index64.
# We still require that this reduces to no more than 128 variants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now actually finalize #3310
Instantiate
prototypein the same way we do fortags_cls.Without it, we get