feat: Allow model_utils.prediction to skip uncertainty calculation#510
Open
MoAly98 wants to merge 7 commits intoscikit-hep:masterfrom
Open
feat: Allow model_utils.prediction to skip uncertainty calculation#510MoAly98 wants to merge 7 commits intoscikit-hep:masterfrom
model_utils.prediction to skip uncertainty calculation#510MoAly98 wants to merge 7 commits intoscikit-hep:masterfrom
Conversation
…ncertainty in ModelPrediction instance
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 2099 2105 +6
Branches 291 292 +1
=========================================
+ Hits 2099 2105 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MoAly98
changed the title
model_utils.prediction to skip uncertainty calculationmodel_utils.prediction to skip uncertainty calculation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #417.
This solution returns zero uncertainty when calculation is skipped, avoiding change in ModelPrediction class.