Skip to content

fix: use Python ints for start/stop when reading a single basket#1605

Open
ariostas wants to merge 2 commits intomainfrom
ariostas/xrootd_single_basket
Open

fix: use Python ints for start/stop when reading a single basket#1605
ariostas wants to merge 2 commits intomainfrom
ariostas/xrootd_single_basket

Conversation

@ariostas
Copy link
Copy Markdown
Member

@ariostas ariostas commented Mar 17, 2026

xrootd refuses to work with NumPy ints, which was preventing reading single baskets with xrootd. I simply converted them to Python ints.

Closes #1582

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.42%. Comparing base (f19065d) to head (3f4dd28).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
Files with missing lines Coverage Δ
src/uproot/behaviors/TBranch.py 83.41% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@ariostas ariostas added this to the v5.7.3 milestone Mar 17, 2026
Copy link
Copy Markdown
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariostas - Excellent catch! Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reading single basket over xrootd

2 participants