feat: add awkward_form method for TMatrixTSym-v5 model#1610
Open
mrzimu wants to merge 1 commit intoscikit-hep:mainfrom
Open
feat: add awkward_form method for TMatrixTSym-v5 model#1610mrzimu wants to merge 1 commit intoscikit-hep:mainfrom
mrzimu wants to merge 1 commit intoscikit-hep:mainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (98.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I encountered a problem similar to issue #359. The difference is: in #359, they were trying to read a
TMatrixTSym<double>directly from a ROOT file, while I'm trying to read it from a TTree.I found that PR #484 did not implement
awkward_formforModel_TMatrixTSym_3c_double_3e__v5, so I've added it.The awkward form I added is derived from the awkward array that was read from a properly generated ROOT file (contains the streamer information of
TMatrixTSym<double>, which allows Uproot to dynamically generate its model). So the form given byModel_TMatrixTSym_3c_double_3e__v5should be consistent with that given by the dynamically-generated model.I haven't added test yet (though I have tested on my PC), since I think it better to create this PR first, then upload the test file to
scikit-hep-testdata. Please let me know if my modification is OK and I shall go ahead (upload test file, add test). :)To reproduce the issue, run:
while the properly generated file can be read as:
issue_file.root.txt
good_file.root.txt