Skip to content

Conversation

@catanzaromj
Copy link
Contributor

This PR fixes a bug with the old codecov github action for uploading code coverage. It also introduces ruff into persim for both linting and formatting. Both of these are modernizations to get persim up to date with common best practices.

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 81.55340% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.40%. Comparing base (39ec0bf) to head (b914492).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
persim/images_kernels.py 50.00% 8 Missing ⚠️
persim/gromov_hausdorff.py 77.77% 3 Missing and 1 partial ⚠️
persim/persistent_entropy.py 66.66% 1 Missing and 3 partials ⚠️
persim/visuals.py 83.33% 1 Missing and 1 partial ⚠️
persim/landscapes/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   79.40%   79.40%   -0.01%     
==========================================
  Files          20       20              
  Lines        1486     1481       -5     
  Branches      327      271      -56     
==========================================
- Hits         1180     1176       -4     
- Misses        228      229       +1     
+ Partials       78       76       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@catanzaromj catanzaromj marked this pull request as ready for review October 1, 2025 22:50
@catanzaromj catanzaromj merged commit 2d50e66 into scikit-tda:master Jan 20, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant