Open
Conversation
nvaytet
reviewed
Mar 9, 2026
Member
nvaytet
left a comment
nvaytet
left a comment
There was a problem hiding this comment.
I don't understand why CI is failing... a vector coordinate mismatch does not seem to originate from these changes...
| email-validator==2.3.0 | ||
| # via scippneutron | ||
| essreduce==26.1.1 | ||
| essreduce==26.3.1 |
Member
There was a problem hiding this comment.
Should this be set as a lower bound in the pyproject.toml?
jl-wynen
force-pushed
the
lookup-error-threshold
branch
from
9a0b187 to
edb8ec9
Compare
Member
Author
This is related to a change in ESSreduce. Not sure yet which, but the coord transform from time to wavelength no longer removes the position. Do you know why? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.