Skip to content

Update LOKI default monitor names to m-prefix convention#248

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/update-loki-monitor-names
Draft

Update LOKI default monitor names to m-prefix convention#248
Copilot wants to merge 2 commits intomainfrom
copilot/update-loki-monitor-names

Conversation

Copy link

Copilot AI commented Mar 12, 2026

LOKI monitor naming was updated to use an m prefix, but loki_default_parameters() still hardcoded the old names, breaking offline users who rely on defaults.

Change

  • src/ess/loki/workflow.py: Update default NeXusMonitorName values in loki_default_parameters():
# Before
NeXusMonitorName[Incident]: 'beam_monitor_1',
NeXusMonitorName[Transmission]: 'beam_monitor_3',

# After
NeXusMonitorName[Incident]: 'beam_monitor_m1',
NeXusMonitorName[Transmission]: 'beam_monitor_m3',
Original prompt

This section details on the original issue you should resolve

<issue_title>Update hardcoded LOKI monitor names to use m-prefix convention</issue_title>
<issue_description>## Context

LOKI monitor naming was recently updated to use an m prefix (e.g., beam_monitor_1beam_monitor_m1, beam_monitor_3beam_monitor_m3).

LokiWorkflow() still hardcodes the old names as defaults:

# Currently in LokiWorkflow defaults:
NeXusMonitorName[Incident] = 'beam_monitor_1'
NeXusMonitorName[Transmission] = 'beam_monitor_3'

These should be updated to:

NeXusMonitorName[Incident] = 'beam_monitor_m1'
NeXusMonitorName[Transmission] = 'beam_monitor_m3'

Impact

In ESSlivedata, we now pass the resolved monitor names from the aux source configuration into the factory, overriding the defaults. So the live dashboard is not affected. However, offline users of LokiWorkflow() who rely on the defaults will get stale names.</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: SimonHeybrock <12912489+SimonHeybrock@users.noreply.github.com>
Copilot AI changed the title [WIP] Update hardcoded LOKI monitor names to use m-prefix convention Update LOKI default monitor names to m-prefix convention Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update hardcoded LOKI monitor names to use m-prefix convention

2 participants