This repository was archived by the owner on Oct 16, 2023. It is now read-only.
Adds refresh method to re-fetch [data-modal]#7
Open
zackkatz wants to merge 2 commits intoscottaohara:mainfrom
Open
Adds refresh method to re-fetch [data-modal]#7zackkatz wants to merge 2 commits intoscottaohara:mainfrom
refresh method to re-fetch [data-modal]#7zackkatz wants to merge 2 commits intoscottaohara:mainfrom
Conversation
See scottaohara#6 for more information. I know this isn't the best solution, but I'm not a great JS developer. Another alternative would be to add something like this: ``` /** * @param {Element} item */ ARIAmodal.addModal = function ( item ) { modal.push( item ); }; ``` and then refactor `setupModal` so it runs only on one modal at a time, then add a new `setupModals` method that would loop through all the items in the `modal` array and run `setupModal` on them. Again, I'm not great at JS. Thank you for the script, and please let me know if I can help with the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #6 for more information.
I know this isn't the best solution, but I'm not a great JS developer.
Another alternative would be to add something like this:
and then refactor
setupModalso it runs only on one modal at a time, then add a newsetupModalsmethod that would loop through all the items in themodalarray and runsetupModalon them.Again, I'm not great at JS. Thank you for the script, and please let me know if I can help with the PR.
Closes #6