Skip to content

Support file and package exclusions for Scala 3.4.2+#541

Merged
ckipp01 merged 1 commit into
scoverage:mainfrom
jozic:support-excluded-files-and-packages-for-scala3
Jul 1, 2024
Merged

Support file and package exclusions for Scala 3.4.2+#541
ckipp01 merged 1 commit into
scoverage:mainfrom
jozic:support-excluded-files-and-packages-for-scala3

Conversation

@jozic

@jozic jozic commented Jun 19, 2024

Copy link
Copy Markdown
Member

fixes #525

@jozic jozic marked this pull request as ready for review June 19, 2024 22:16
@jozic

jozic commented Jun 19, 2024

Copy link
Copy Markdown
Member Author

@ckipp01 please review when you have a minute

@TonioGela

Copy link
Copy Markdown

+1 on this

@ckipp01 ckipp01 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @jozic! I left a nit, but it's not a huge deal, probably helpful for us to track in the future. I'll go ahead and merge now and then cut a release.

Comment thread README.md
Any code between two such comments will not be instrumented or included in the
coverage report.

Note: Comments exclusion works only for Scala2.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: Comments exclusion works only for Scala2.
Note: Comment exclusion works only for Scala2.

Also, if there is an issue for this in the Scala 3 issue tracker can we link it here?

@ckipp01 ckipp01 merged commit 76a39fb into scoverage:main Jul 1, 2024
@jozic jozic deleted the support-excluded-files-and-packages-for-scala3 branch July 1, 2024 18:36
@ckipp01

ckipp01 commented Jul 3, 2024

Copy link
Copy Markdown
Member

Sorry had an issue with the release due to some sonatype changes, but everything should be good to go now and released 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package / file exclusion does not work with Scala 3

3 participants