-
Notifications
You must be signed in to change notification settings - Fork 6
fix: building in zkvm guest #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #457 will not alter performanceComparing Summary
|
frisitano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment inline about making both crates optional. We should also sync the rollup node from genesis to check if this feature is valid. I will run a sync of sepolia rollup node using this branch on a vm and report back once I have results.
45d314f to
3d2bf5d
Compare
|
@frisitano as you requested, but this brokes |
I hadn't considered this issue. I think it's better if we revert to the solution you had previously, such that we have support for |
|
I successfully synced a node from genesis using |
dogeos using codec crate in guest, zstd won't compile on such target.