Skip to content

Conversation

@lightsing
Copy link
Member

dogeos using codec crate in guest, zstd won't compile on such target.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #457 will not alter performance

Comparing fix/codec-guest-compat (5970629) with main (5f74b29)

Summary

✅ 2 untouched

@Thegaram Thegaram requested a review from georgehao December 9, 2025 07:40
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment inline about making both crates optional. We should also sync the rollup node from genesis to check if this feature is valid. I will run a sync of sepolia rollup node using this branch on a vm and report back once I have results.

@lightsing lightsing force-pushed the fix/codec-guest-compat branch from 45d314f to 3d2bf5d Compare January 5, 2026 04:56
@lightsing
Copy link
Member Author

@frisitano as you requested, but this brokes --all-features, what's your opinion on this? shall we update the ci or allow enable all features? cc @Thegaram

@frisitano
Copy link
Collaborator

@frisitano as you requested, but this brokes --all-features, what's your opinion on this? shall we update the ci or allow enable all features? cc @Thegaram

I hadn't considered this issue. I think it's better if we revert to the solution you had previously, such that we have support for --all-features. Sorry about the confusion.

@frisitano
Copy link
Collaborator

I successfully synced a node from genesis using ruzstd, so no concerns around compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants