Draft
Conversation
read_lazyread_lazy
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big open question is what is
backedmode even supposed to be at this point? Right now we don't attach an "open" dataset toXbut instead reopen every time (which is presumably for a good reason? open file handles?). So the boolean for indicating backed mode chekcs thatX is None, which has a knockdown list of side effects.In general, I think a plan of attack:
backedmode reopens the file repeatedlyadata[subset].X = ...doesn't write to disk?zarr.Groupnecessary for reopening or get rid the concept of reopening if possible (preferably the later)AnnData.file{name}even should be for in the wake of thisread_lazykwarg for not using dask #2147