deprecate MuData methods whose AnnData analogs will be deprecated in 0.13#131
deprecate MuData methods whose AnnData analogs will be deprecated in 0.13#131ilia-kats wants to merge 3 commits intoscverse:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 90.98% 91.13% +0.14%
==========================================
Files 11 11
Lines 1797 1838 +41
==========================================
+ Hits 1635 1675 +40
- Misses 162 163 +1
🚀 New features to boost your workflow:
|
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
Very wonderful! I think this helper is awesome!
| from collections.abc import Callable, Mapping, Sequence | ||
|
|
||
|
|
||
| def deprecated(version: str, msg: str | None = None): |
There was a problem hiding this comment.
This seems like a good candidate for scverse-misc right?
We don't seem to have this in AnnData: https://anndata.readthedocs.io/en/stable/generated/anndata.AnnData.var_vector.html#anndata.AnnData.var_vector i.e., the deprecation does not appear in the docs
There was a problem hiding this comment.
you guys have this mixin class that explicitly hides deprecated methods from the docs. But I'm happy to move this to scverse-misc.
There was a problem hiding this comment.
Ah true, I guess we will deprecate in 0.13 but maybe this is a nice alternative? I'd like to hear from @flying-sheep what his take is. My feeling is that this is a cleaner solution than deleting from the docs.
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
2 participants
No description provided.