Use timing safe string comparison in checkAPIKey#12
Merged
seveibar merged 2 commits intoseamapi:mainfrom Sep 5, 2023
Merged
Conversation
bencmbrook
changed the title
bencmbrook
force-pushed
the
security-fix-back-to-original
branch
from
167022a to
8114363
Compare
codetheweb
approved these changes
Sep 5, 2023
seveibar
approved these changes
Sep 5, 2023
Contributor
|
released in 1.1.1 |
Contributor
|
Thanks @bencmbrook ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More about timing attacks here: https://security.stackexchange.com/questions/83660/simple-string-comparisons-not-secure-against-timing-attacks
Closes #1 (it seems the other subtasks were completed)