-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Default timeouts #181
Copy link
Copy link
Closed
Labels
B-rfcBlocked: Request for comments. More discussion would help move this along.Blocked: Request for comments. More discussion would help move this along.
Milestone
Metadata
Metadata
Assignees
Labels
B-rfcBlocked: Request for comments. More discussion would help move this along.Blocked: Request for comments. More discussion would help move this along.
Not having a default timeout means that anyone who doesn't consider a maximum time length for a request can end up with a hung thread (with sync client) for quite a while. This could even not manifest during testing and development, and only happen in rare occasions in production, where the long hang without a cancel hurts a user.
Now, some people need a really long timeout, such as if doing "long polling", or on flaky wireless connections. But as long as there is an option for them to increase (disable?) the timeout, they should be fine.
So, what's a proper default? 30 seconds?