Change http3 feature to use rustls with no provider.#2796
Open
TroyKomodo wants to merge 7 commits intoseanmonstar:masterfrom
Open
Change http3 feature to use rustls with no provider.#2796TroyKomodo wants to merge 7 commits intoseanmonstar:masterfrom
TroyKomodo wants to merge 7 commits intoseanmonstar:masterfrom
Conversation
TroyKomodo
force-pushed
the
patch-1
branch
2 times, most recently
from
d912263 to
bfece1b
Compare
Eveeifyeve
reviewed
Aug 25, 2025
Owner
|
Just to chime in here, I think this is likely a good idea. I noticed it might need something from Quinn, maybe, but whenever there's no more blockers, happy to merge. |
Eveeifyeve
approved these changes
Sep 2, 2025
Eveeifyeve
left a comment
Eveeifyeve
left a comment
There was a problem hiding this comment.
LGTM, however please fix the CI/CD issues before you merge. 😉
Author
|
Forgot to request a re-review. |
Eveeifyeve
approved these changes
Oct 3, 2025
|
Fix the ci issue and rebase then this will be ready to merge however lgtm. |
Author
Strange, cargo fmt doesnt seem to do anything... |
Owner
|
Yea, seems like rustfmt fails to understand when macros include files (which we use to support wasm or not). So our CI had to change to |
Author
|
I am not sure how to fix the linux/nightly and msrv ci failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2566