Skip to content

feat: Upgrade node-hcl to version that supports merging tfvars files #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbckr merged 2 commits into from
Sep 2, 2025
Merged

feat: Upgrade node-hcl to version that supports merging tfvars files #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be39932
feat(hcl): upgrade node-hcl to version that supports merging tfvars f…
bbckr Aug 30, 2025
f5d7579
Try different YAML syntax
bbckr Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr-title-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
# Configure types to match semantic-release rules from package.json
types: >
types: |
feat
fix
docs
Expand Down
2 changes: 1 addition & 1 deletion plugins/scaffolder-backend-module-hcl/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@backstage/config": "^1.2.0",
"@backstage/plugin-scaffolder-node": "^0.4.10",
"@backstage/types": "^1.2.0",
"@seatgeek/node-hcl": "^1.0.0",
"@seatgeek/node-hcl": "^2.0.0",
"fs-extra": "^11.2.0",
"zod": "^3.23.8"
},
Expand Down
5 changes: 0 additions & 5 deletions plugins/scaffolder-backend-module-hcl/src/actions/hcl/hcl.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ describe('createHclMergeAction', () => {
}
type = string
}

`;

const mockCtx = {
Expand Down Expand Up @@ -106,7 +105,6 @@ describe('createHclMergeAction', () => {
}
type = string
}

`;

const mockCtx = {
Expand Down Expand Up @@ -158,7 +156,6 @@ describe('createHclMergeFilesAction', () => {
description = "Name to be used on all the resources as identifier"
type = string
}

`;

const aPath = `${mockContext.workspacePath}/${randomBytes(12).toString(
Expand Down Expand Up @@ -252,7 +249,6 @@ describe('createHclMergeFilesAction', () => {
}
}


module "my_module" {
my_map = {
"map_a" = {
Expand All @@ -269,7 +265,6 @@ module "my_module" {
var = local.my_var
version = "0.0.2"
}

`;

const aPath = `${mockContext.workspacePath}/${randomBytes(12).toString(
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9595,10 +9595,10 @@
version "0.0.0"
uid ""

"@seatgeek/node-hcl@^1.0.0":
version "1.1.1"
resolved "https://registry.yarnpkg.com/@seatgeek/node-hcl/-/node-hcl-1.1.1.tgz#13e9a2127a665d8ebedeed31c28e7e4aef6033cc"
integrity sha512-pvqj6rzI8sG8/O62vcaj4WL4F6eQSVStGE+97GAONk1a8WLwL4yF68MXo8hfzUSsN+ljUTMoF1qnJECpHpAyLg==
"@seatgeek/node-hcl@^2.0.0":
version "2.0.0"
resolved "https://registry.yarnpkg.com/@seatgeek/node-hcl/-/node-hcl-2.0.0.tgz#ca0d538bbd99b501a5cf20c0c83d913c791109df"
integrity sha512-f4B9DFVjAcXlEYQVxsWSvXYKPZLhds4nZQ0fSeqW0c+Q+xdjg296CmtjxOsvOt2tip6q6KtmJPejxXQ2C/gceA==
dependencies:
fs-extra "^11.2.0"

Expand Down