Skip to content

fix(availability-sync): handle resolution check for single-server setups#2334

Merged
gauthier-th merged 2 commits intodevelopfrom
fallenbagel/fix/availability-sync-single-server-resolution
Jan 26, 2026
Merged

fix(availability-sync): handle resolution check for single-server setups#2334
gauthier-th merged 2 commits intodevelopfrom
fallenbagel/fix/availability-sync-single-server-resolution

Conversation

@fallenbagel
Copy link
Copy Markdown
Collaborator

@fallenbagel fallenbagel commented Jan 25, 2026 •
edited
Loading

Description

PR #1543 introduced resolution checking to check 4k from non4k media when users have both server types configured with the same service. This caused a regression as this causes false deletions for users with only a single non4k service when radarr upgrades file to 4k resolution.

This PR only applies resolution to checking when both 4k and non4k servers are configured. Otherwise then if file exists then it counts as available.

How Has This Been Tested?

  • Have one non-4k Radarr service
  • Upgrade movie from 1080p -> 4k
  • Run media availability sync job
  • Regression no longer occurs

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

@fallenbagel fallenbagel added the bug Something isn't working label Jan 25, 2026
@fallenbagel fallenbagel requested a review from a team as a code owner January 25, 2026 23:07
@fallenbagel fallenbagel requested a review from Copilot January 26, 2026 00:22
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

gauthier-th
gauthier-th previously approved these changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauthier-th gauthier-th enabled auto-merge (squash) January 26, 2026 08:12
@fallenbagel fallenbagel requested a review from Copilot January 26, 2026 08:17
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fallenbagel fallenbagel force-pushed the fallenbagel/fix/availability-sync-single-server-resolution branch from 47d52db to 08cf511 Compare January 26, 2026 12:26
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fallenbagel fallenbagel force-pushed the fallenbagel/fix/availability-sync-single-server-resolution branch from 08cf511 to ae55b60 Compare January 26, 2026 12:34
@fallenbagel fallenbagel requested a review from Copilot January 26, 2026 12:34
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fallenbagel fallenbagel force-pushed the fallenbagel/fix/availability-sync-single-server-resolution branch from ae55b60 to 281283f Compare January 26, 2026 12:41
@fallenbagel fallenbagel requested a review from Copilot January 26, 2026 12:41
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fallenbagel fallenbagel force-pushed the fallenbagel/fix/availability-sync-single-server-resolution branch from 281283f to 58bfef3 Compare January 26, 2026 12:45
@seerr-team seerr-team deleted a comment from Copilot AI Jan 26, 2026
@fallenbagel fallenbagel requested a review from Copilot January 26, 2026 12:46
@fallenbagel
fix(availability-sync): handle resolution check for single-server setups
4962c3b 
PR #1543 introduced resolution checking to check 4k from non4k media when users have both server
types configured with the same service. Howerver, this causes false deletions for users with only a
single non4k service when radarr upgrades file to 4k resolution. This fix only applies resolution to
checking when both 4k and non4k servers are configured. Otherwise then if file exists then it counts
as available.
@fallenbagel fallenbagel force-pushed the fallenbagel/fix/availability-sync-single-server-resolution branch from 58bfef3 to 4962c3b Compare January 26, 2026 13:01
@fallenbagel fallenbagel requested review from Copilot and removed request for Copilot January 26, 2026 13:01
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fallenbagel fallenbagel force-pushed the fallenbagel/fix/availability-sync-single-server-resolution branch from 751f492 to a383c70 Compare January 26, 2026 13:25
@fallenbagel
Copy link
Copy Markdown
Collaborator Author

fallenbagel commented Jan 26, 2026 •
edited
Loading

@gauthier-th should be ready for re-review now

What a messy review thread lmfao
Copilot raised some good points and as I was making changes on mobile it led to typos & silly mistakes which Copilot flagged, leading to more fixes and back-and-forth 😆

@gauthier-th
Copy link
Copy Markdown
Member

gauthier-th commented Jan 26, 2026

Copilot raised some good points and as I was making changes on mobile it led to typos & silly mistakes which Copilot flagged, leading to more fixes and back-and-forth 😆

Yep, that's more clear like that

@gauthier-th gauthier-th merged commit 0f7d296 into develop Jan 26, 2026
8 checks passed
@gauthier-th gauthier-th deleted the fallenbagel/fix/availability-sync-single-server-resolution branch January 26, 2026 19:58
@fallenbagel fallenbagel mentioned this pull request Jan 27, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@0xSysR3ll 0xSysR3ll 0xSysR3ll approved these changes

@gauthier-th gauthier-th gauthier-th approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fallenbagel @gauthier-th @0xSysR3ll