This repository was archived by the owner on May 22, 2019. It is now read-only.
Fix shelves dictionary keys#31
Open
lepisma wants to merge 1 commit intosefakilic:masterfrom
lepisma:patch-shelves
Open
Fix shelves dictionary keys#31lepisma wants to merge 1 commit intosefakilic:masterfrom lepisma:patch-shelves
lepisma wants to merge 1 commit intosefakilic:masterfrom
lepisma:patch-shelves
Conversation
|
Just to chime in here: I came across the same error and implemented the same fix, and now everything works fine. Seems like the CI build failed for other reasons, unrelated to this commit. @sefakilic, any chance you could merge this PR? |
Author
|
CI build fails because of this There are pretty old PRs pending too, I guess this repo can be considered inactive? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26