[ATSCALE-44228] row security property to UDA#44
Conversation
stanislavtrifonov88
commented
Feb 9, 2026
stanislavtrifonov88
commented
- updated the UDA attribtes to include row_security property
- the rule is that either row_securty or dimension + name properties can be defined
|
All contributors have signed the CLA ✍️ ✅ |
stanislavtrifonov88
requested review from
Copilot,
diannewood and
svetoslavpetkov
There was a problem hiding this comment.
Pull request overview
Updates the SML model reference documentation to support including row_security in user-defined aggregate (UDA) attribute references, aligning the schema docs with row-security capabilities elsewhere in the model spec.
Changes:
- Add
row_securityto theAttributeReferenceentity definition in the model schema section. - Update UDA
attributesdocumentation to describe conditional requiredness forname/dimensionvsrow_security.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `name`: String, required if `row_security` is undefined. The name of the dimension attribute to | ||
| include. These values are used to group the summarized metric data in | ||
| the resulting aggregate table. Note that user-defined aggregate | ||
| definitions are fixed: they do not include every level of a hierarchy | ||
| unless they are explicitly defined. | ||
|
|
||
| - `dimension`: String, required. The dimension to which the attribute | ||
| - `dimension`: String, required if `row_security` is undefined. The dimension to which the attribute | ||
| defined by `name` belongs. | ||
|
|
There was a problem hiding this comment.
The docs here describe conditional requiredness, but they don’t clearly state the mutual-exclusion rule from the PR description (either row_security OR (dimension + name), not a mix) and they also allow partial specification (e.g., name without dimension). Consider rewriting this section to explicitly require dimension and name together when row_security is not set, and to state that row_security must not be combined with them.
| defined by `name` belongs. | ||
|
|
||
| - `row_security`: String, required if `dimension` and `name` are | ||
| undefined. Allows row security to be included in a user defined aggregate. |
There was a problem hiding this comment.
row_security description should be more specific about what value is expected (e.g., the unique_name of a row_security object) and use consistent hyphenation with the rest of the doc ("user-defined aggregate" instead of "user defined aggregate").
| undefined. Allows row security to be included in a user defined aggregate. | |
| undefined. Specifies the `unique_name` of a `row_security` object to include in a user-defined aggregate. |
|
I have read the CLA Document and I hereby sign the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
