Allow manual selection of units on results entry#2201
Conversation
+ A list of units can be defined for an analysis service + The user can select the units when submitting data.
update the code so that the default value is always listed first. update the code so that the units rendered beside the result do not wrap.
xispa
left a comment
xispa
left a comment
There was a problem hiding this comment.
Thanks for your efforts!
Seems the unit is not store properly
- Type result:
- Select a unit from the selection list:
- On save, the unit next to the result changes to default, different from the selected one:
- On submit, the unit has not changed, although the selected one was different from default:
| item["Method"] = api.get_title(method) | ||
| item["replace"]["Method"] = get_link_for(method, tabindex="-1") | ||
|
|
||
| def _on_unit_choice_change(self, uid=None, value=None, item=None, **kw): |
There was a problem hiding this comment.
You don't need this if you do it differently. Hint: You don't need a "UnitChoices" column, but a "Unit" column that becomes editable (with a choices list) when the analysis have multiple units set. Otherwise, the column "Unit" is not rendered.
There was a problem hiding this comment.
Removed UnitChoice column. Unit it column is only rendered when needed.
There was a problem hiding this comment.
I think you can remove this function _on_unit_choice_change, cause on_unit_change is used instead
There was a problem hiding this comment.
Thank you, removed.
Implemented corrections from senaite#2201 (review)
|
Thank you @xispa for all your comments. I have implemented your comments (ac745f9). A list of units for selection can be provided here: The unit column will only render if a selection of units is provided. I have also updated the code so that the units render after the uncertainty. and for the selection list; The units change is now stored properly:
On submit: Improvement: |
xispa
left a comment
xispa
left a comment
There was a problem hiding this comment.
Thanks, you are almost there!. Just two minor changes (see comments) and please add an entry at CHANGES.rst. Also, do a pull first, cause I've merged 2.x into your branch and done some commits to make Flake8 happy.
| item["Method"] = api.get_title(method) | ||
| item["replace"]["Method"] = get_link_for(method, tabindex="-1") | ||
|
|
||
| def _on_unit_choice_change(self, uid=None, value=None, item=None, **kw): |
There was a problem hiding this comment.
I think you can remove this function _on_unit_choice_change, cause on_unit_change is used instead
xispa
changed the title
xispa
changed the title
Implemented xispa requested changes on Jan 19. see senaite#2201
|
Hi @xispa, |
xispa
changed the title
4 participants
Description of the issue/feature this PR addresses
Linked issue: https://github.com/senaite/senaite.core/issues/
Current behavior before PR
Desired behavior after PR is merged
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.