You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @ramonski I missed this one, I wasn't sure if getNumberOfSamples need to be added as an index instead waking up the object even though it seemed we are already got the object from the previous lines.
Regarding the sorting, it is a bit tricky because any index would need to get updated as soon as samples are assigned/unassigned from a batch. Therefore, I would rely on the manual sorting.
Maybe a good idea would be to move the count method directly to the Batch content class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
On th batch listing(batches) add a column that shows the number of samples

Current behavior before PR
On the Batch Listing(Batches) there isn't a column that shows the number of samples that are on the batch
Desired behavior after PR is merged
To have a column that shows the number of samples that are on a batch.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.