Bump actions/upload-artifact from 5 to 6

[dependabot]

Bumps actions/upload-artifact from 5 to 6.

Release notes

Sourced from actions/upload-artifact's releases.

v6.0.0

v6 - What's new

[!IMPORTANT] actions/upload-artifact@v6 now runs on Node.js 24 (runs.using: node24) and requires a minimum Actions Runner version of 2.327.1. If you are using self-hosted runners, ensure they are updated before upgrading.

Node.js 24

This release updates the runtime to Node.js 24. v5 had preliminary support for Node.js 24, however this action was by default still running on Node.js 20. Now this action by default will run on Node.js 24.

What's Changed

• Upload Artifact Node 24 support by @​salmanmkc in actions/upload-artifact#719
• fix: update @​actions/artifact for Node.js 24 punycode deprecation by @​salmanmkc in actions/upload-artifact#744
• prepare release v6.0.0 for Node.js 24 support by @​salmanmkc in actions/upload-artifact#745

Full Changelog: actions/upload-artifact@v5.0.0...v6.0.0

Commits

• b7c566a Merge pull request #745 from actions/upload-artifact-v6-release
• e516bc8 docs: correct description of Node.js 24 support in README
• ddc45ed docs: update README to correct action name for Node.js 24 support
• 615b319 chore: release v6.0.0 for Node.js 24 support
• 017748b Merge pull request #744 from actions/fix-storage-blob
• 38d4c79 chore: rebuild dist
• 7d27270 chore: add missing license cache files for @​actions/core, @​actions/io, and mi...
• 5f643d3 chore: update license files for @​actions/artifact@​5.0.1 dependencies
• 1df1684 chore: update package-lock.json with @​actions/artifact@​5.0.1
• b5b1a91 fix: update @​actions/artifact to ^5.0.0 for Node.js 24 punycode fix
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

---

Resolves #745
Resolves #744
Resolves actions/upload-artifact#719
Resolves actions/upload-artifact#744
Resolves actions/upload-artifact#745

[github-actions]

🤖 Claude Code Review

Code Review Analysis

Summary

This PR updates the GitHub Actions upload-artifact action from v5 to v6 across three workflow files. This is a straightforward dependency update with no functional code changes.

---

Detailed Checklist Review

Code Quality

✅ Code follows style guide

• No code style issues - this is a GitHub Actions workflow configuration change only
• YAML syntax is correct and follows GitHub Actions conventions

✅ No commented-out code

• No commented code present in the diff

✅ Meaningful variable names

• N/A - No new variables introduced

✅ DRY principle followed

• The same update is consistently applied across all three workflow files (darwin, linux, windows)
• This consistency is appropriate for maintaining parallel test workflows

✅ Defects/Security Analysis

• No bugs, logic errors, or security vulnerabilities introduced
• The v5 to v6 upgrade is a standard dependency update
• No race conditions, memory leaks, or edge cases affected
• ⚠️ Note: Verify that actions/upload-artifact@v6 maintains backward compatibility with existing artifact handling. The v6 version may have breaking changes around artifact naming and merging behavior.

✅ Project Configuration

• Checked for .claude/CLAUDE.md - no project-specific requirements that would affect this workflow change

---

Testing

✅ Unit tests for new functions

• N/A - No new functions added

✅ Integration tests for new endpoints

• N/A - No new endpoints

✅ Edge cases covered

• N/A - This is a dependency version bump

✅ Test coverage > 80%

• No changes to test coverage; workflows themselves will test this when run

---

Documentation

✅ README updated if needed

• Not required - GitHub Actions version updates don't typically need README documentation

✅ API docs updated

• N/A - No API changes

✅ Inline comments for complex logic

• N/A - No complex logic added

⚠️ CHANGELOG.md updated

• Not visible in this diff. Should verify if CHANGELOG.md needs an entry for this dependency update
• Recommendation: Add entry like "Updated actions/upload-artifact from v5 to v6 in CI workflows"

✅ Markdown formatting

• N/A - No markdown files modified

---

Security

✅ No hardcoded credentials

• No credentials present

✅ Input validation implemented

• N/A - No new inputs

✅ Proper error handling

• Existing error handling unchanged

✅ No sensitive data in logs

• No changes to logging behavior

✅ No license files or AQAAAD strings

• No license files or suspicious strings in the diff

---

Final Recommendations

Minor Items to Verify:

1. CHANGELOG.md Update (.github/workflows/go-test-*.yaml)

   • Consider adding an entry documenting this dependency update

2. Breaking Changes Check

   • Verify actions/upload-artifact@v6 compatibility:
     • V6 may have changes to artifact merging behavior
     • Multiple uploads with the same name may behave differently
     • All three workflows use name: cover.out and name: test-log - confirm v6 handles these correctly

3. Workflow Testing

   • After merge, monitor the first workflow runs to ensure artifacts upload successfully
   • Verify that downstream jobs consuming these artifacts still work correctly

---

Overall Assessment

✅ APPROVED - This is a clean, consistent dependency update with no code quality, security, or functional issues. The change follows best practices for keeping GitHub Actions up to date. Just verify CHANGELOG.md and monitor the first workflow runs post-merge.

Automated code review analyzing defects and coding standards

[github-actions]

🤖 Claude Code Review

Code Review Analysis

Summary

This PR updates the GitHub Actions upload-artifact action from v5 to v6 across three workflow files. This is a straightforward dependency update with no functional code changes.

---

Code Quality

✅ Code follows style guide

No code style issues. The changes are limited to GitHub Actions workflow version updates, which maintain consistent YAML formatting.

✅ No commented-out code

No commented-out code present in the diff.

✅ Meaningful variable names

N/A - No variable names changed.

✅ DRY principle followed

The same update pattern is consistently applied across all three workflow files, which is appropriate for this type of change.

✅ Identify Defects

No defects identified. However, important consideration:

• actions/upload-artifact@v6 introduces breaking changes from v5, particularly around artifact naming and merging behavior
• Potential issue: All three workflows use the same artifact name cover.out, which in v6 will cause conflicts if these jobs run in parallel within the same workflow run
• Files affected:
  • .github/workflows/go-test-darwin.yaml:41-43
  • .github/workflows/go-test-linux.yaml:42-44
  • .github/workflows/go-test-windows.yaml:40-42

Recommendation: Consider using unique artifact names like cover-darwin.out, cover-linux.out, cover-windows.out or review the v6 migration guide for proper artifact merging strategy.

✅ Project memory configuration

No .claude/CLAUDE.md file found in the repository to consider.

---

Testing

⚠️ Unit tests for new functions

N/A - No new functions added. However, this change should be tested in the CI/CD pipeline to ensure artifact uploads work correctly with v6.

⚠️ Integration tests for new endpoints

N/A - No new endpoints.

⚠️ Edge cases covered

The workflows should be tested to verify that artifact uploads succeed with v6 and that the artifacts can be downloaded/used by dependent jobs (if any).

⚠️ Test coverage > 80%

N/A - Infrastructure change only.

---

Documentation

⚠️ Readme updated if needed

No README updates needed for this internal CI/CD change, unless the project documents its CI/CD workflow versions.

✅ API docs updated

N/A - No API changes.

✅ Inline comments for complex logic

N/A - Simple version bump, no complex logic.

❌ CHANGELOG.md updated

No CHANGELOG.md update included in this PR. While this is a minor infrastructure change, dependency updates should typically be documented.

Files to update: CHANGELOG.md (if it exists in the repository)

✅ Markdown files follow CommonMark

N/A - No markdown files modified.

---

Security

✅ No hardcoded credentials

No credentials present in the changes.

✅ Input validation implemented

N/A - No input handling in this change.

✅ Proper error handling

The workflows already have if: always() conditions on test log uploads, which is appropriate.

✅ No sensitive data in logs

No changes to logging behavior.

✅ No license files checked in

No .lic files or AQAAAD strings in the diff.

---

Additional Notes

Breaking Changes in upload-artifact@v6

Be aware of these key changes from v5 to v6:

1. Artifact naming: Multiple uploads with the same name will overwrite each other instead of merging
2. Download behavior: The corresponding download-artifact action must also be updated to v6
3. Retention defaults: Check if retention policies have changed

Action Items

1. Critical: Verify that the duplicate cover.out artifact names won't cause issues in your workflows
2. Update CHANGELOG.md to document this dependency update
3. Ensure any jobs that download these artifacts are also updated to use actions/download-artifact@v6
4. Test the workflows in a non-production branch to confirm artifact upload/download behavior

---

Overall Assessment

Status: ✅ Approved with recommendations

This is a clean dependency update with no code quality or security issues. The main concern is ensuring the artifact naming strategy is compatible with v6's behavior changes. Please address the artifact naming consideration and CHANGELOG update before merging.

Automated code review analyzing defects and coding standards