[INFRA] Optional tdl

[eseiler]

Tests are a bit annoying, and snippets will need to be built with tdl (readme_snippet).

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
sharg-parser	✅ Ready (Inspect)	Visit Preview	Jan 31, 2024 0:59am

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (60abdbe) 91.90% compared to head (82a96f7) 91.91%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #218   +/-   ##
=======================================
  Coverage   91.90%   91.91%           
=======================================
  Files          17       17           
  Lines        1594     1595    +1     
=======================================
+ Hits         1465     1466    +1     
  Misses        129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SGSSGene]

Thank you!

[eseiler]

💅

[h-2]

Thank you for the quick fix again!

One thing though: right now you are assuming that the library is always built by CMake, because you are referring to SHARG_HAS_TDL but this has no default value in the code. In practice, this works for me right now, because #if SHARG_HAS_TDL evaluates to false if SHARG_HAS_TDL is not defined. But a better solution would IMHO be to set a default in the source code. Either =0 or based on the presence of TDL headers, e.g.:

#ifndef SHARG_HAS_TDL
#define SHARG_HAS_TDL __has_include(<TDLHEADER>)
#endif

That way, everything would still work well in header-only land.

[eseiler]

Thank you for the quick fix again!

One thing though: right now you are assuming that the library is always built by CMake, because you are referring to SHARG_HAS_TDL but this has no default value in the code. In practice, this works for me right now, because #if SHARG_HAS_TDL evaluates to false if SHARG_HAS_TDL is not defined. But a better solution would IMHO be to set a default in the source code. Either =0 or based on the presence of TDL headers, e.g.:

#ifndef SHARG_HAS_TDL
#define SHARG_HAS_TDL __has_include(<TDLHEADER>)
#endif

That way, everything would still work well in header-only land.

I was thinking about adding that in the platform.hpp, but then didn't do it, because it'll evaluate to false anyway :D
Maybe I'll add that to be more correct.

The header-check would cause issues if TDL is installed system-wide.
Then the <tdl/tdl.h> would be available, but you wouldn't link against it.