You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❗ Current head f1a2163 differs from pull request most recent head 19a3e9b. Consider uploading reports for the commit 19a3e9b to get more accurate results
As far as I am concerned, you can get rid of the dot! But I would still wrap strings (and paths!) in quotes, because the user needs to be able to distinguish " " and "" (or "foo " and "foo").
If you are concerned that this will cause ambiguity with literal quotes, you could choose more exotic quotes, like the ones used for code in markdown (`) or the french ones: »foo«
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #222
To-do
Test output on terminal
Questions
.at the end? (If there is a validator message, it will take care of prepending.)std::quotedalso escapes quote inside strings. Do we want that?