[TEST] Add EXPECT_THROW_MSG

[eseiler]

This streamlines checking that a statement throws a specific error with a specific description.

Using a macro has the advantage that we get the correct traceback and can use the existing googletest code.

The incorrect description check will also print the diff (like when comparing two strings) if googletest deems it necessary to do so.

Example output for the four cases (line numbers are correct):

../../../../test/unit/parser/parser_design_error_test.cpp:297: Failure
Expected: parser.parse() throws an exception of type sharg::design_error.
  Actual: it throws nothing.

../../../../test/unit/parser/parser_design_error_test.cpp:308: Failure
Expected: parser.add_section("") throws an exception of type sharg::user_input_error.
  Actual: it throws sharg::design_error with description "add_section may only be used before calling parse().".

../../../../test/unit/parser/parser_design_error_test.cpp:311: Failure
parser.add_subsection("") throws the correct exception, but the description is incorrect.
Expected equality of these values:
  Expected
    Which is: "add_subseption may only be used before calling parse()."
  Actual
    Which is: "add_subsection may only be used before calling parse()."

../../../../test/unit/parser/parser_design_error_test.cpp:318: Failure
Expected: throw 42 throws an exception of type sharg::design_error.
  Actual: it throws an unknown exception.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
sharg-parser	✅ Ready (Inspect)	Visit Preview	Feb 27, 2024 3:38pm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (64399ce) to head (3295fa5).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   95.13%   95.13%           
=======================================
  Files          18       18           
  Lines        1728     1728           
=======================================
  Hits         1644     1644           
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SGSSGene]

Why not using EXPECT_THROW?
https://google.github.io/googletest/reference/assertions.html#EXPECT_THROW

[eseiler]

Why not using EXPECT_THROW?
https://google.github.io/googletest/reference/assertions.html#EXPECT_THROW

Because it doesn't check the message of the exception. Sometimes you want to check that the correct message is emitted, e. g., design_error is thrown in many places with different messages.

[smehringer]

We currently do not have a repo for infrastructure stuff like we have for std stuff right? This is very valuable for seqan3 too

[eseiler]

I also added it to seqan3, but we don't have a repo for infra stuff